Fixes SUPPRESS_ERROR_PAGE warning after webview_flutter_android upgrade #2182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
How override error pages if we no longer have disableDefaultErrorPage ? |
|
@EArminjon I can't say. This was a feature that was never launched in webkit:
This is a change performed in WebViewFeature.java almost a year ago. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connection with issue(s)
Resolve issue #2150
Testing and Review Notes
The SUPPRESS_ERROR_PAGE feature was discontinued according to this change in Webkit's WebViewFeature.java.
The recent upgrade of webkit to 1.10.0 in webview_flutter_android causes the webview to be null.
This suppresses references to SUPPRESS_ERROR_PAGE.