Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom post action for batch discount code creation #157

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

rjacobso
Copy link
Contributor

@rjacobso rjacobso commented May 4, 2020

@rjacobso
Copy link
Contributor Author

@tareqtms did you not see this or is there a reason you don't want to merge this? Should it be implemented as a new child resource of PriceRule instead? I've used the suggested change to successfully create batch coupon code jobs.

@tareqtms
Copy link
Contributor

@rjacobso
I see there are 2 merge commits, but cannot see which branch is merged to which and what are the changes.

@rjacobso
Copy link
Contributor Author

@tareqtms

The merge commits were simply to bring my local copy up to date with your recent merges / changes.

The only intended change should be the addition of 3 lines to PriceRule.php as seen here: https://github.com/phpclassic/php-shopify/pull/157/files

@tareqtms
Copy link
Contributor

@rjacobso
I will review again soon and then merge. Thanks.

@tareqtms
Copy link
Contributor

tareqtms commented Jun 2, 2020

@rjacobso
As per the doc, the Batch operation has also option to get info by batch id /admin/api/2020-04/price_rules/{price_rule_id}/batch/{batch_id}.json and also the discount codes /admin/api/2020-04/price_rules/507328175/batch/173232803/discount_codes.json. As the custom post actions work, this will not allow that. Can you please think about it and come up with an idea, otherwise we may screw up the whole batch thing here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants