Restrict attribute completion using targets #2629
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
przepompownia
changed the title
|
Any idea how to better read target names from an attribute? At the moment it digs into |
przepompownia
commented
Apr 16, 2024
|
|
||
| if ($node->getEndPosition() > $truncatedLength) { | ||
| $node = $this->parser->parseSourceFile($truncatedSource)->getDescendantNodeAtPosition($truncatedLength); | ||
| } |
There was a problem hiding this comment.
@dantleech @mamazu It's hacky and probably worth a better replacement, but passes all current tests.
- on truncated source cannot determine attribute context (whether it's attached to class, method, etc.) because the relevant information is after the cursor
- without truncation: the data set
does not use variables declared after offset ainWorseParameterCompletorTest(and not only) does not pass. - inserting additional space after the cursor before parsing does not break any existing behavior but seems to help to get the correct node if there are no white space after the cursor (and avoid get the replacement for truncated document).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2199