Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rails 7.2 compatibility #1477

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

theodorton
Copy link

@theodorton theodorton commented Jun 2, 2024

  • Wrote good commit messages.
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests. - Not relevant; refactoring to support Rails 7.2
  • Added an entry to the Changelog if the new
    code introduces user-observable changes. - Not relevant; refactoring to support Rails 7.2
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.

@fatkodima
Copy link
Contributor

fatkodima commented Jun 15, 2024

Can you please squash your commits into 1? You also need to update this line -

ACTIVERECORD_LT = "< 7.2" # not enforced in gemspec

That CI failure regarding coverage - these coverage metrics are pretty pointless imo, I would prefer to just remove it from the project.

@theodorton theodorton force-pushed the rails-7-2 branch 2 times, most recently from 5ffca52 to 5a62060 Compare June 17, 2024 08:23
@theodorton
Copy link
Author

I've fixed the compatibility spec, added the new appraisal to the CI matrix and squashed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants