DOC: More doc fix for dtype_backend #59071
Open
+103
−107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhshadrach
reviewed
Jun 22, 2024
| * ``"pyarrow"``: returns pyarrow-backed nullable :class:`ArrowDtype` | ||
| DataFrame. | ||
| * ``"numpy_nullable"``: returns with nullable-dtype-backed | ||
| * ``"pyarrow"``: returns with pyarrow-backed nullable :class:`ArrowDtype` |
There was a problem hiding this comment.
I don't think these are correct - the default here really is numpy_nullable. Compare this to to_numeric where the default is lib.no_default.
There was a problem hiding this comment.
My apologies for the oversight. I am correcting it now. I have also conducted a thorough review of the remaining change, and I think that all changes have been made appropriately.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dtype_backendparameter description to make them all consistent #54104, following DOC: Changeto_numeric'sdtype_backenddefault doc #59021doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.