-
-
Notifications
You must be signed in to change notification settings - Fork 815
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Antd to v5.12+ #3780
base: develop
Are you sure you want to change the base?
Update Antd to v5.12+ #3780
Conversation
Passing run #17190 ↗︎Details:
Review all test suite changes for PR #3780 ↗︎ |
… to the ant-layout instead of all elements
… the custom default theme
Storybook is going to be weird in general, as are embeds if I had to guess. Most of the general global rules in the v4 less file have been moved to the There's also discrepancies in, for example, the chromatic snaphot for "Custom Page Content" and the actual published storybook. It shows the link decorations but none are there in the actual storybook or the actual page. Some of the mappings still need clarification. Hovers are weird. Most of them follow the |
I'm really impressed it's working as well as it is, nice job! We can certainly wrap layouts if that's what's needed. |
Closes #2359
See #2359 (comment) for additional context
styles/ant-overrides.scss
need to be adjusted to match specificity.Theme
inserting into the DOM. But antd theming works at least.Will make changes over time, but doable from here.