Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Antd to v5.12+ #3780

Draft
wants to merge 26 commits into
base: develop
Choose a base branch
from
Draft

Conversation

mahmed2000
Copy link
Contributor

@mahmed2000 mahmed2000 commented Jun 11, 2024

Closes #2359

See #2359 (comment) for additional context

  • Some of the existing less variables did not have a clean mapping
  • Some of the CSS selectors in styles/ant-overrides.scss need to be adjusted to match specificity.
  • A number of things were changed that make things look very weird, like the global error modal. Padding, etc needs to be overridden.
  • Its not completely clean, and computes the theme twice on the main page (on load to match admin and on Theme inserting into the DOM. But antd theming works at least.

Will make changes over time, but doable from here.

Copy link

cypress bot commented Jun 11, 2024

Passing run #17190 ↗︎

0 87 0 0 Flakiness 0

Details:

Merge c57949d into 4c0233a...
Project: Owncast Web Frontend Commit: 1c3d33e1b1 ℹ️
Status: Passed Duration: 04:09 💡
Started: Jun 21, 2024 8:30 AM Ended: Jun 21, 2024 8:34 AM

Review all test suite changes for PR #3780 ↗︎

@mahmed2000
Copy link
Contributor Author

Storybook is going to be weird in general, as are embeds if I had to guess.

Most of the general global rules in the v4 less file have been moved to the .ant-layout class instead of body or html, which means those won't apply to most rules unless wrapped in a layout (like the page and not storybook/embeds) or they're set manually as global rules. Ideal situation would be wrap everything in at least the antd layout to maintain old consistency.

There's also discrepancies in, for example, the chromatic snaphot for "Custom Page Content" and the actual published storybook. It shows the link decorations but none are there in the actual storybook or the actual page.

Some of the mappings still need clarification. Hovers are weird. Most of them follow the --primary-hover-color which is blue, but some (like the active tab) follow the intended(?) light purple like v4.

@gabek
Copy link
Member

gabek commented Jun 14, 2024

I'm really impressed it's working as well as it is, nice job! We can certainly wrap layouts if that's what's needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to Ant Design v5
2 participants