Implement admin password hashing with bcrypt #3754
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing run #16935 ↗︎
Details:
Review all test suite changes for PR #3754 ↗︎ |
|||||||||||||||
gabek
reviewed
May 31, 2024
|
All looks great in my usage testing! Though I went to use the updated admin to try to change the password there and I ran into #3775, so I haven't yet been able to test that because of that bug. The only change there, though, would be not displaying the password in the admin UI. |
|
When using another browser I had no problems, so something must have been cached. |
|
I'll have to fix this conflict, but then we can merge this in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2495
Works, but not tested extensively. Stream keys still plaintext.
Edit:
api tests are failing because they still expect the raw password instead of the hash, will get to them in either a few hours or tomorrowEdit 2: Tests work now, just grabbed the first package for bcrypt I found, hasn't been updated in a while. Lmk if there's a different package you'd rather use, otherwise this should be good?