-
-
Notifications
You must be signed in to change notification settings - Fork 815
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support versions of ffmpeg greater than 5 #3476
base: develop
Are you sure you want to change the base?
Conversation
Passing run #12248 ↗︎Details:
Review all test suite changes for PR #3476 ↗︎ |
Note: Ignore the conflicts, the web project was built for this PR just for testing. It will be reverted before it gets merged in. |
This pull request has not had any activity in 30 days. Since things move fast it's best to get PRs merged in. If this PR addresses a previously filed issue that needs to be resolved please work to get it merged in, or allow somebody else to work on a fix. This PR will be closed if no further activity occurs. Thank you for your contributions! |
Meer |
Could you add detail to your comment? |
2 failed tests on run #16078 ↗︎Details:
|
Test | Artifacts | |
---|---|---|
Online readwrite chat embed > Show change name modal |
Screenshots
Video
|
|
Online readwrite chat embed > Close name change modal |
Screenshots
Video
|
This splits out
vaapi
codec into two completely different options.Vaapi (Legacy)
is what has always existed in Owncast, and supports ffmpeg versions older than 5.Vaapi
is the new, up-to-date support for Vaapi and requires support for ffmpeg v5 and above.When running this code it will migrate you from using
vaapi
toVaapi (Legacy)
, making the assumption if you were using vaapi before you were also using an older version of ffmpeg. If you need to change it to the new version, you must manually make that change.