-
-
Notifications
You must be signed in to change notification settings - Fork 870
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add check_date support #8440
base: master
Are you sure you want to change the base?
Add check_date support #8440
Conversation
it'd be good to whitelist what types it's added to (amenity, shop, craft, leisure, office etc keys. There may be others). |
also please use DCO, put |
I don't recall seeing it, but it might exist :)
I think an exact date is not needed. It might make sense for mappers, but for the most users it'll be just confusing. Hence as @Zverik has rightly noted in #7036 (comment) a boolean "outdated" flag might be enough. What if the map file is very outdated on user's device? |
Utilize the url validator as a placeholder for validation. Should likely check if it's a date string as the spec Signed-off-by: Eivind Samseth <[email protected]>
Signed-off-by: Eivind Samseth <[email protected]>
Would it be better to avoid complicating the generator (and increasing the map file size) and implement this as an optional online feature? What are the pros and cons? |
For context there are ~1 million check_date: https://taginfo.openstreetmap.org/keys/check_date If OSM get to the ~60 million POIs as in Overture, then we're talking 1.26 GB (No clue if this is correct, but I'd think this is an upper bound for an inefficient implementation without compression?) |
And if the "this POI might be outdated" is used, then I'm sure the map size increase will be almost negligible. |
Does two things:
![Screenshot 2024-06-10 at 23 00 29](https://private-user-images.githubusercontent.com/62468530/338345188-4f2bd8fe-7768-4ea3-8686-1d1100ceb2a5.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTk0MDA4NjMsIm5iZiI6MTcxOTQwMDU2MywicGF0aCI6Ii82MjQ2ODUzMC8zMzgzNDUxODgtNGYyYmQ4ZmUtNzc2OC00ZWEzLTg2ODYtMWQxMTAwY2ViMmE1LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MjYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjI2VDExMTYwM1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTEzODg1OWU2MzZjYjE4YzBkMTVmMWZmYjkzYzk1MWFmYjE3YjczZGEzNjc3Mzk2YzE5ODE2ZjNmMDJjMjQyMWImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.oGN-UwAsqNmUbRgvW1dKPuFBebwUop7OJwhc0Aa4X78)
Imports check_date to the map generator
Displays the contents of check_date on POIs
Open questions:
Related to #7882 #7036 #6811