[ios] replace circle checkbox image (radioBtnOff/On) with rounded rect #8438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmmm, I'll update the icons then. Actually I was hoping they'll be visually the same size due to squares looking "heavier" than circles. Turns out the round shapes had virtually no insets |
biodranik
reviewed
Jun 10, 2024
rtsisyk
approved these changes
Jun 11, 2024
|
Could you please try these SVGs instead?
|
Signed-off-by: Kiryl Kaveryn <[email protected]>
kirylkaveryn
force-pushed
the
ios/update-radio-button-image
branch
from
26caef4
to
fdcb09b
Compare
Thanks! I've updated the PR description screenshots. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8389
@euf thanks a lot for the new icon!
Nit: the image you provide looks great but has a little bit thicker insets and because of that it looks smaller in comparison with the old circle. - fixedBefore/After:
