-
-
Notifications
You must be signed in to change notification settings - Fork 870
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display major roads earlier on z6 (world overview map) #8436
Conversation
The benefit of empty map areas is clear. But the polluted map in dense areas looks less readable (region names/cities are more important here than roads). So again we're blocked from doing it perfectly by the absent option to use different styling in dense/non-dense areas. |
IMHO added roads are subtle enough to not affect legibility of captions in a significant way. @organicmaps/styles WDYT? Its better to test on a real device (make sure you test the main style, not the outdoors). Road lines in screenshots above may look thick when viewed via a desktop screen (which is usually lower dpi than vs=3 screenshots above). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like an improvement to me 👍
Dynamic styling, as @biodranik said, would be even better someday, but for now it's already better
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- I like roads on z6
- drules_proto_design.bin - ??
Please, make a correct "Regenerated" commit.
Signed-off-by: Konstantin Pastbin <[email protected]>
Signed-off-by: Konstantin Pastbin <[email protected]>
c08fcd7
to
fda75f2
Compare
Fixed! |
In less populous areas its hard to get a road network overview for longer trips.
Sometimes its even impossible to see connections to the nearest displayed/labeled city.
(especially common in areas further from the equator, see #5427)
Making major roads (motorway, trunk) display one zoom level earlier helps a lot:
![Screenshot_20240610-142035](https://private-user-images.githubusercontent.com/18434508/338172320-0d3a28bd-9190-410f-9162-57c5304dcdbb.jpg?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTk0MDAwMDMsIm5iZiI6MTcxOTM5OTcwMywicGF0aCI6Ii8xODQzNDUwOC8zMzgxNzIzMjAtMGQzYTI4YmQtOTE5MC00MTBmLTkxNjItNTdjNTMwNGRjZGJiLmpwZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MjYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjI2VDExMDE0M1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWY5YTA4ZGNkZjE5OTExZDU3ZjIwN2UzNjQwOGJmYTNjNDUyMzMxOGZiMTFhYzQ5OWQ0YWNjMWI3MGQ5MWUxODYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.ZswsTm_ieZho5b5Bhd8dvmR2KGWhFJyqw0QlXmsWOyQ)
On z6 I've made them much more subtle than on z7. This way they're traceable / useful in "empty" areas still and at the same time they don't stand out too much in dense areas:
![Screenshot_20240610-142439](https://private-user-images.githubusercontent.com/18434508/338173259-7cd6f2a0-191d-4586-9d46-5942b8a8c84c.jpg?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTk0MDAwMDMsIm5iZiI6MTcxOTM5OTcwMywicGF0aCI6Ii8xODQzNDUwOC8zMzgxNzMyNTktN2NkNmYyYTAtMTkxZC00NTg2LTlkNDYtNTk0MmI4YThjODRjLmpwZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MjYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjI2VDExMDE0M1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTE3MzcyM2Y4MTJkZWE1MGVlNzJmYWRiMmUxZDRmNWI3ZDNjZTIxNjI2M2EyODdmOTk5MzQyOTlkNmQ1MWExM2ImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.J0SyGaeRfbsFTTT75QwbVXpwYjvmZ_oqxBDtWyq982g)
E.g. compare to z7 where roads are much more prominent:
![Screenshot_20240610-142534](https://private-user-images.githubusercontent.com/18434508/338173340-b4870b0f-b6fe-4aa5-b376-243abed9c195.jpg?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTk0MDAwMDMsIm5iZiI6MTcxOTM5OTcwMywicGF0aCI6Ii8xODQzNDUwOC8zMzgxNzMzNDAtYjQ4NzBiMGYtYjZmZS00YWE1LWIzNzYtMjQzYWJlZDljMTk1LmpwZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MjYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjI2VDExMDE0M1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWE1N2M1MTY0ZDU4NDczZjY1YTg2ZDA2Y2ViNmU1ZjA4MjUxNDFhYzVkNGYzZWVjYTY2ZTEwNDJkZjk0ODQ3NmYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.3qfDk2HHuIPA1pujR096i-Opry9_kI5Yy0SHmwod0aY)
The size of the World map doesn't increase (+5Kb only) as no additional geometry bucket is introduced.
To test it locally:
tools/unix/build_omim.sh -r generator_tool
../omim-build-release/generator_tool --generate_index=true --data_path=data/ --output="World"
to update map's visibility indexRelated to: