Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display major roads earlier on z6 (world overview map) #8436

Merged
merged 2 commits into from
Jun 18, 2024

Conversation

pastk
Copy link
Contributor

@pastk pastk commented Jun 10, 2024

In less populous areas its hard to get a road network overview for longer trips.
Sometimes its even impossible to see connections to the nearest displayed/labeled city.
(especially common in areas further from the equator, see #5427)

Screenshot_20240610-142020

Making major roads (motorway, trunk) display one zoom level earlier helps a lot:
Screenshot_20240610-142035

Screenshot_20240610-142317

On z6 I've made them much more subtle than on z7. This way they're traceable / useful in "empty" areas still and at the same time they don't stand out too much in dense areas:
Screenshot_20240610-142439

E.g. compare to z7 where roads are much more prominent:
Screenshot_20240610-142534

The size of the World map doesn't increase (+5Kb only) as no additional geometry bucket is introduced.

To test it locally:

  • switch to PR's branch
  • build generator_tool tools/unix/build_omim.sh -r generator_tool
  • run ../omim-build-release/generator_tool --generate_index=true --data_path=data/ --output="World" to update map's visibility index

Related to:

@pastk pastk requested review from biodranik, vng and a team June 10, 2024 12:08
@biodranik
Copy link
Member

The benefit of empty map areas is clear. But the polluted map in dense areas looks less readable (region names/cities are more important here than roads).

So again we're blocked from doing it perfectly by the absent option to use different styling in dense/non-dense areas.

@pastk
Copy link
Contributor Author

pastk commented Jun 16, 2024

But the polluted map in dense areas looks less readable (region names/cities are more important here than roads).

IMHO added roads are subtle enough to not affect legibility of captions in a significant way.
Moreover such dense regions (as China above) are quite rare. E.g. in the most of Western Europe added z6 roads look helpful and not cluttered.

@organicmaps/styles WDYT?

Its better to test on a real device (make sure you test the main style, not the outdoors). Road lines in screenshots above may look thick when viewed via a desktop screen (which is usually lower dpi than vs=3 screenshots above).

Copy link
Contributor

@euf euf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like an improvement to me 👍

Dynamic styling, as @biodranik said, would be even better someday, but for now it's already better

Copy link
Member

@vng vng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • I like roads on z6
  • drules_proto_design.bin - ??

Please, make a correct "Regenerated" commit.

Signed-off-by: Konstantin Pastbin <[email protected]>
Signed-off-by: Konstantin Pastbin <[email protected]>
@pastk
Copy link
Contributor Author

pastk commented Jun 17, 2024

Please, make a correct "Regenerated" commit.

Fixed!

@vng vng merged commit 6155392 into master Jun 18, 2024
15 checks passed
@vng vng deleted the pastk-styles-z6-trunks branch June 18, 2024 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants