Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove subways bg, add line casing #8431

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pastk
Copy link
Contributor

@pastk pastk commented Jun 9, 2024

image

image

TODO

  • put casing color and opacity into styles
  • night mode
  • check the PT routing
  • add casing/outline to stop circles
  • ? render lines under POI icons/labels ? (now they're above everything)
  • remove unused code

Related to

@pastk pastk requested review from biodranik and a team June 9, 2024 19:16
@pastk
Copy link
Contributor Author

pastk commented Jun 9, 2024

Actually it changes how people use the subway layer.

Now its: enable for a limited time while checking the scheme or routing.

It'll become more like "set and forget" unless subway lines do really get into one's way.

@pastk
Copy link
Contributor Author

pastk commented Jun 9, 2024

Also its likely people will inquire more often why subway lines don't follow the real tracks..

@patepelo
Copy link
Contributor

@pastk Thanks for this change.

? render lines under POI icons/labels ? (now they're above everything)

Can it be rendered under POIs only when zooming in, but above when zooming out?

@pastk
Copy link
Contributor Author

pastk commented Jun 10, 2024

Can it be rendered under POIs only when zooming in, but above when zooming out?

I think complexity of implementation doesn't justify it..

I don't think POIs above subway lines will make the lines noticeably less prominent / traceable. E.g. main orange roads are very well visible, but subway lines are thicker and brighter even.

So its more about a schematic / overlay layer feel vs lines integrated into the map.

@RedAuburn
Copy link
Sponsor Member

i like it, but this should be a temporary improvement on the way to the full PT map style imo

Copy link
Contributor

@euf euf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For a temporary improvement it is really nice! LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove transparent white layer over the map when subway is enabled
4 participants