Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recognise more surface types, treat fine_gravel as "formed" by default #8391

Merged
merged 2 commits into from
Jun 25, 2024

Conversation

@pastk pastk requested a review from vng June 5, 2024 15:08
@pastk
Copy link
Contributor Author

pastk commented Jun 16, 2024

@vng please review when you have time

@vng
Copy link
Member

vng commented Jun 25, 2024

UPD: For future, please, add path<->footway transformation tests in osm_type_tests.cpp
For better understanding like input tags -> highway=path/footway as a result.

@pastk
Copy link
Contributor Author

pastk commented Jun 25, 2024

UPD: For future, please, add path<->footway transformation tests in osm_type_tests.cpp For better understanding like input tags -> highway=path/footway as a result.

Yeap there is a OsmType_HighwayTypesConversion section already, its just it doesn't make sense to add all possible surface values there.

@vng vng merged commit a1ae97e into master Jun 25, 2024
9 checks passed
@vng vng deleted the pastk-generator-surfaces branch June 25, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants