Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[android] Add website:booking key #8340

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Arthur-GYT
Copy link
Member

@Arthur-GYT Arthur-GYT requested a review from a team as a code owner May 30, 2024 19:20
Arthur-GYT added 4 commits May 30, 2024 21:23
@Arthur-GYT Arthur-GYT marked this pull request as draft May 30, 2024 19:25
@biodranik
Copy link
Member

There are 738 tags worldwide tags with this value. Is it really useful? Any website of a bookable place usually have a large Booking button on it.

@Arthur-GYT
Copy link
Member Author

There are 738 tags worldwide tags with this value. Is it really useful? Any website of a bookable place usually have a large Booking button on it.

Not necessarily. Typically, some restaurants use a third-party service to manage reservations, like this one

https://www.openstreetmap.org/node/6296221506

@Arthur-GYT Arthur-GYT marked this pull request as ready for review May 30, 2024 19:42
@Arthur-GYT
Copy link
Member Author

BTW, it's ready for review ^^

@Arthur-GYT
Copy link
Member Author

There are 738 tags worldwide tags with this value. Is it really useful? Any website of a bookable place usually have a large Booking button on it.

Not necessarily. Typically, some restaurants use a third-party service to manage reservations, like this one

https://www.openstreetmap.org/node/6296221506

And @biodranik , not all restaurants have websites, but they can use third-party services for bookings.

@biodranik
Copy link
Member

And @biodranik , not all restaurants have websites, but they can use third-party services for bookings.

Did you study existing tags? Is it a popular case? How many cases where the website tag is missing, but website:booking is present? Won't it be logical for the restaurant to add a booking link into website tag if a restaurant doesn't have its own website?

@Arthur-GYT
Copy link
Member Author

Did you study existing tags? Is it a popular case? How many cases where the website tag is missing, but website:booking is present? Won't it be logical for the restaurant to add a booking link into website tag if a restaurant doesn't have its own website?

I'll take another case I know. A hairdresser who has a site but their booking system is not up to date on the site and does not link to the current (and working) one.

https://www.openstreetmap.org/node/8775652782
https://les-barbiers.com/
https://maps.app.goo.gl/HSCuyTWgVUG4PdL1A

@Arthur-GYT
Copy link
Member Author

Arthur-GYT commented Jun 1, 2024

@biodranik

At present, I don't think the number of nodes with this tag is very representative. If Organic Maps supports it, maybe it will encourage people to map the tag and maybe we'll get more cases where the booking system is dissociated from the website.

And I think the youth of this tag, as well as its late standardization, means there aren't many knots with it ¯_(ツ)_/¯

@biodranik
Copy link
Member

In your example, the right thing is to ask the website owner to update the booking link.

Organic Maps tries to focus on the most important and most popular use cases for most users first. Imagine that many insignificant/unnecessary fields are added to Organic Maps Editor. Would it be easier/better to use in this case?

To optimize the process, it makes sense to create and discuss an issue before implementing it (and also get/discuss stats about its use cases).

@Arthur-GYT Arthur-GYT marked this pull request as draft June 5, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants