-
-
Notifications
You must be signed in to change notification settings - Fork 870
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[android] Add website:booking
key
#8340
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Arthur-GYT <[email protected]>
Signed-off-by: Arthur-GYT <[email protected]>
Signed-off-by: Arthur-GYT <[email protected]>
Signed-off-by: Arthur-GYT <[email protected]>
249fd9b
to
a34d533
Compare
There are 738 tags worldwide tags with this value. Is it really useful? Any website of a bookable place usually have a large Booking button on it. |
a34d533
to
c291c75
Compare
Not necessarily. Typically, some restaurants use a third-party service to manage reservations, like this one |
Signed-off-by: Arthur-GYT <[email protected]>
c291c75
to
60a2d5c
Compare
BTW, it's ready for review ^^ |
And @biodranik , not all restaurants have websites, but they can use third-party services for bookings. |
Did you study existing tags? Is it a popular case? How many cases where the website tag is missing, but website:booking is present? Won't it be logical for the restaurant to add a booking link into website tag if a restaurant doesn't have its own website? |
I'll take another case I know. A hairdresser who has a site but their booking system is not up to date on the site and does not link to the current (and working) one. https://www.openstreetmap.org/node/8775652782 |
At present, I don't think the number of nodes with this tag is very representative. If Organic Maps supports it, maybe it will encourage people to map the tag and maybe we'll get more cases where the booking system is dissociated from the website. And I think the youth of this tag, as well as its late standardization, means there aren't many knots with it ¯_(ツ)_/¯ |
In your example, the right thing is to ask the website owner to update the booking link. Organic Maps tries to focus on the most important and most popular use cases for most users first. Imagine that many insignificant/unnecessary fields are added to Organic Maps Editor. Would it be easier/better to use in this case? To optimize the process, it makes sense to create and discuss an issue before implementing it (and also get/discuss stats about its use cases). |
All is in the title ^^.
https://wiki.openstreetmap.org/wiki/Key:website:booking