Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Torchfx dynamic shapes split slice support #25172

Open
wants to merge 20 commits into
base: master
Choose a base branch
from
Open

Torchfx dynamic shapes split slice support #25172

wants to merge 20 commits into from
+115 −78

Conversation

cavusmustafa
Copy link
Contributor

@cavusmustafa cavusmustafa commented Jun 22, 2024 •
edited
Loading

Details:

  • Split and slice op translations updated for dynamic shape requirements
  • Impacts ChatGLM variants

Tickets:

cavusmustafa and others added 18 commits May 28, 2024 16:11
@cavusmustafa
Permanent fix for dynamic shapes in reshape translation
63e32de
@cavusmustafa
Arange translation dynamic ranked input fix for stop
02067eb
@cavusmustafa
Missing include added for arange translation
6672e9a
@cavusmustafa
TorchFX: Dynamic shape support for full translation
a759e08
@cavusmustafa
Missing include added to full translation
5a16ba6
@ynimmaga
Dynamic shape support for llama3
1d545b2
@cavusmustafa
Merge branch 'openvinotoolkit:master' into torchfx_dynamic_shapes_add…
924b368 
…itional_support
@cavusmustafa
Merge pull request #7 from ynimmaga/dyn_shapes
063b33b 
Dynamic shape support for llama3
@cavusmustafa
Fix for expand LLama2 support
45c5510
@cavusmustafa @mvafin
Update src/frontends/pytorch/src/op/full.cpp
b432d90 
Co-authored-by: Maxim Vafin <[email protected]>
@cavusmustafa @mvafin
Update src/frontends/pytorch/src/op/full.cpp
97dde80 
Co-authored-by: Maxim Vafin <[email protected]>
@cavusmustafa
Create helper function to create shape from individual dimensions
4190329
@cavusmustafa
Arange translation 1D end value check
ab05fe6
@cavusmustafa
Code formating
b725f97
@cavusmustafa
Typo fix for 1D end check in arange
99cab9c
@cavusmustafa
Code formating for expand translation
a85c0be
@cavusmustafa
Updated input check for slice translation
d496c96
@cavusmustafa
Merge branch 'master' into torchfx_dynamic_shapes_additional_support
38426de
@github-actions github-actions bot added category: Python API OpenVINO Python bindings category: CPP API OpenVINO CPP API bindings category: PyTorch FE OpenVINO PyTorch Frontend labels Jun 22, 2024
@cavusmustafa cavusmustafa marked this pull request as ready for review June 24, 2024 05:43
@cavusmustafa cavusmustafa requested review from a team as code owners June 24, 2024 05:43
mvafin
mvafin reviewed Jun 26, 2024
View reviewed changes
src/bindings/python/src/openvino/frontend/pytorch/fx_decoder.py
@@ -316,6 +316,9 @@ def _raw_input(self, index):
def num_of_outputs(self):
return len(self.outputs())

def num_of_users(self):
return len(self.pt_module.users)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if each output of split is used more ten once? Will those uses be here too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvafin mvafin mvafin left review comments

@slyalin slyalin Awaiting requested review from slyalin slyalin is a code owner automatically assigned from openvinotoolkit/openvino-pytorch-frontend-maintainers

@rkazants rkazants Awaiting requested review from rkazants rkazants is a code owner automatically assigned from openvinotoolkit/openvino-pytorch-frontend-maintainers

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
category: CPP API OpenVINO CPP API bindings category: Python API OpenVINO Python bindings category: PyTorch FE OpenVINO PyTorch Frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cavusmustafa @mvafin @ynimmaga