move darknet and caffe in opencv_contrib #3740
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkurt
reviewed
Jun 7, 2024
| @@ -0,0 +1,233 @@ | |||
| if(WINRT) | |||
| ocv_module_disable(dnn) | |||
dkurt
reviewed
Jun 7, 2024
| ocv_target_compile_definitions(${the_module} PRIVATE "HAVE_PROTOBUF=1") | ||
|
|
||
| if(PROTOBUF_UPDATE_FILES) | ||
| file(GLOB proto_files "${CMAKE_CURRENT_LIST_DIR}/src/tensorflow/*.proto" "${CMAKE_CURRENT_LIST_DIR}/src/caffe/opencv-caffe.proto" "${CMAKE_CURRENT_LIST_DIR}/src/onnx/opencv-onnx.proto") |
|
|
||
| TEST(Test_Caffe, memory_read) | ||
| { | ||
| const std::string proto = cv::samples::findFile("dnn/bvlc_googlenet.prototxt"); |
There was a problem hiding this comment.
Please add false to every large model findFile - Let's test build only for now
| // or tort (including negligence or otherwise) arising in any way out of | ||
| // the use of this software, even if advised of the possibility of such damage. | ||
| // | ||
| //M*/ |
There was a problem hiding this comment.
Prefer to use a short license version:
// This file is part of OpenCV project.
// It is subject to the license terms in the LICENSE file found in the top-level directory
// of this distribution and at http://opencv.org/license.html.
dkurt
reviewed
Jun 7, 2024
There was a problem hiding this comment.
Common test files can be removed and reused from dnn. Just add the following line to CMakeLists.txt after ocv_add_accuracy_tests(${dnn_runtime_libs}):
target_include_directories(opencv_test_dnnlegacy PRIVATE "${OPENCV_MODULE_opencv_dnn_LOCATION}/test")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.