Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: watch metrics-config in agent mode #2186

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

antoinedeschenes
Copy link
Contributor

Reopening #1899

What does this PR change?

  • Allows agent mode to watch the metrics-config ConfigMap, this was unexpected as the costmodel execution behaves correctly. Documentation doesn't mention agent mode missing that feature.

Does this PR relate to any other PRs?

How will this PR impact users?

  • Enables disabledMetrics support in agent mode

Does this PR address any GitHub or Zendesk issues?

  • Closes ...

How was this PR tested?

Running locally port-forwarded to a remote cluster and Prometheus, with a provisioned metrics-config configmap.

  • Log outputs:
    INF Starting metrics init with disabled metrics: [service_selector_labels statefulSet_match_labels 
    deployment_match_labels kube_namespace_labels kube_node_labels kube_pod_labels]
    
  • curl localhost:9005/metrics output doesn't contain the above metrics once this PR is applied.

Does this PR require changes to documentation?

  • No, there are no mentions of the missing feature in agent mode.

Have you labeled this PR and its corresponding Issue as "next release" if it should be part of the next Opencost release? If not, why not?

@mattray mattray added opencost OpenCost issues vs. external/downstream P2 Estimated Priority (P0 is highest, P4 is lowest) E2 Estimated level of Effort (1 is easiest, 4 is hardest) labels Oct 5, 2023
@AjayTripathy
Copy link
Contributor

@mbolt35 is this something that makes sense for agentmode?

@AjayTripathy
Copy link
Contributor

@nikovacevic actually since Bolt is out

@nikovacevic
Copy link
Contributor

@AjayTripathy will try to get to it this week

@mattray
Copy link
Collaborator

mattray commented Nov 30, 2023

Assigning to Kubecost Engineering for review

@nikovacevic
Copy link
Contributor

Apologies, I did not get to this, obviously. @mbolt35 is back -- Bolt, do you want to sync on this, and decide together whether or not this makes sense?

Copy link

This pull request has been marked as stale because it has been open for 90 days with no activity. Please remove the stale label or comment or this pull request will be closed in 5 days.

@github-actions github-actions bot added the Stale label Feb 29, 2024
Copy link

vercel bot commented Feb 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
opencost ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 29, 2024 7:39pm

Copy link

sonarcloud bot commented Feb 29, 2024

@github-actions github-actions bot removed the Stale label Mar 1, 2024
Copy link

This pull request has been marked as stale because it has been open for 90 days with no activity. Please remove the stale label or comment or this pull request will be closed in 5 days.

@github-actions github-actions bot added the Stale label May 30, 2024
@mattray mattray removed the Stale label May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E2 Estimated level of Effort (1 is easiest, 4 is hardest) needs-follow-up opencost OpenCost issues vs. external/downstream P2 Estimated Priority (P0 is highest, P4 is lowest)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants