-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: watch metrics-config in agent mode #2186
base: develop
Are you sure you want to change the base?
feat: watch metrics-config in agent mode #2186
Conversation
Signed-off-by: Antoine Deschênes <[email protected]>
@mbolt35 is this something that makes sense for agentmode? |
@nikovacevic actually since Bolt is out |
@AjayTripathy will try to get to it this week |
Assigning to Kubecost Engineering for review |
Apologies, I did not get to this, obviously. @mbolt35 is back -- Bolt, do you want to sync on this, and decide together whether or not this makes sense? |
This pull request has been marked as stale because it has been open for 90 days with no activity. Please remove the stale label or comment or this pull request will be closed in 5 days. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request has been marked as stale because it has been open for 90 days with no activity. Please remove the stale label or comment or this pull request will be closed in 5 days. |
Reopening #1899
What does this PR change?
Does this PR relate to any other PRs?
How will this PR impact users?
Does this PR address any GitHub or Zendesk issues?
How was this PR tested?
Running locally port-forwarded to a remote cluster and Prometheus, with a provisioned metrics-config configmap.
curl localhost:9005/metrics
output doesn't contain the above metrics once this PR is applied.Does this PR require changes to documentation?
Have you labeled this PR and its corresponding Issue as "next release" if it should be part of the next Opencost release? If not, why not?