Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bqmodel and bqbiol annotations merged. #2080

Open
luciansmith opened this issue Nov 28, 2022 · 0 comments
Open

bqmodel and bqbiol annotations merged. #2080

luciansmith opened this issue Nov 28, 2022 · 0 comments

Comments

@luciansmith
Copy link

Please include a short description of problem here
https://github.com/opencobra/cobratoolbox/blob/37c922c422a19d731da66e81059ec0989db39418/src/base/io/utilities/SBML/getBioQualifiers.m

lists several qualifiers in a single list, but some of them come from different lists; see:

https://web.archive.org/web/20211204231945/http://co.mbine.org/specifications/qualifiers

In particular, 'isDerivedFrom', 'isInstanceOf', and 'hasInstance' are in the Model Qualifiers list, but not the Biology Qualifiers list (aka bqmodel but not bqbiol). In addition, 'is' and 'isDescribedBy' are in both lists.

If people feel like these terms should be added to bqbiol in addition to bqmodel, that can probably be done, but in the meantime, it's probably best to put the only-in-bqmodel terms into the accepted namespace.

I hereby confirm that I have:

I looked at the source code and that was it. Issue from sbmlteam/libsbml#283 (cf @GwennyGit).

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant