-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parallelized opentelemetry-go/sdk/resource/auto.go Detect function #5402
base: main
Are you sure you want to change the base?
Conversation
a07d773
to
d1faa6d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5402 +/- ##
=====================================
Coverage 84.2% 84.2%
=====================================
Files 269 269
Lines 22008 22027 +19
=====================================
+ Hits 18546 18565 +19
- Misses 3133 3134 +1
+ Partials 329 328 -1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is missing performance impact evaluation.
Please provide proof this is not impacting memory usage and what impact it has on computational time.
4ec10d6
to
94416a2
Compare
a67333a
to
565d337
Compare
fbcb3a9
to
b6bc1ec
Compare
This will need a changelog entry. |
1b706de
to
2cd8040
Compare
e412862
to
d971d9f
Compare
@MrAlias is there anything more thats missing |
5488db6
to
075aea1
Compare
Co-authored-by: Damien Mathieu <[email protected]>
075aea1
to
e1c98da
Compare
e1c98da
to
f1fa383
Compare
thats solves #5401