Add type overloads to methods #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxyng
requested changes
Jun 6, 2024
ollama/_client.py
Outdated
| system: str = '', | ||
| template: str = '', | ||
| context: Optional[Sequence[int]] = None, | ||
| stream: bool = False, |
There was a problem hiding this comment.
This is incorrect since it creates an overlap between the two overloads
Suggested change
| stream: bool = False, | |
| stream: Literal[False] = False, |
ollama/_client.py
Outdated
| system: str = '', | ||
| template: str = '', | ||
| context: Optional[Sequence[int]] = None, | ||
| stream: bool = True, |
There was a problem hiding this comment.
Suggested change
| stream: bool = True, | |
| stream: Literal[True] = True, |
mxyng
reviewed
Jun 14, 2024
ollama/_client.py
Outdated
| self, | ||
| model: str = '', | ||
| messages: Optional[Sequence[Message]] = None, | ||
| stream: Literal[False] = False, |
There was a problem hiding this comment.
Suggested change
| stream: Literal[False] = False, | |
| stream: bool = False, |
mxyng
reviewed
Jun 18, 2024
| images: Optional[Sequence[AnyStr]] = None, | ||
| options: Optional[Options] = None, | ||
| keep_alive: Optional[Union[float, str]] = None, | ||
| ) -> Mapping[str, Any]: ... |
There was a problem hiding this comment.
this is minor but it'd be better if ... was on a newline. it's easier to read and harder to miss
mxyng
approved these changes
Jun 18, 2024
|
poetry doesn't let me move the ellipsis to a new line, lmk and I can just revert and merge |
ok let's go with the previous, inline style :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In reference to #132