Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

obs-qsv11: Fix CBR Spike #10902

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

thyintel
Copy link
Contributor

@thyintel thyintel commented Jun 20, 2024

Description

CBR improvement for new Intel platform, the peak bitrate is now down to 120% on average from 200% while keeping same bitrate and quality.

This PR will not build until VPL update (predicted by end of this month).

Motivation and Context

This change has been made to decrease the CBR spike on new Intel platforms.

How Has This Been Tested?

new Intel platforms on various driver versions

Types of changes

  • Performance enhancement (non-breaking change which improves efficiency)

Checklist:

  • [ x] My code has been run through clang-format.
  • [ x] I have read the contributing document.
  • [ x] My code is not on the master branch.
  • [ x] The code has been tested.
  • [ x] All commit messages are properly formatted and commits squashed where appropriate.
  • [ x] I have included updates to all appropriate documentation.

@WizardCM WizardCM added Bug Fix Non-breaking change which fixes an issue Enhancement Improvement to existing functionality labels Jun 22, 2024
@RytoEX
Copy link
Member

RytoEX commented Jun 26, 2024

This PR will not build until VPL update (predicted by end of this month).

Even when the new update is available, this code will probably need ifdef'd on the libvpl version, because obs-qsv11 is available on Linux where we do not control the version of libvpl available. On Ubuntu 22.04, which we still support, the version of libvpl available is 2022.1.0 (API 2.6). On Ubuntu 24.04, the version of libvpl available is 2023.3.0 (API 2.9).

@thyintel
Copy link
Contributor Author

This PR will not build until VPL update (predicted by end of this month).

Even when the new update is available, this code will probably need ifdef'd on the libvpl version, because obs-qsv11 is available on Linux where we do not control the version of libvpl available. On Ubuntu 22.04, which we still support, the version of libvpl available is 2022.1.0 (API 2.6). On Ubuntu 24.04, the version of libvpl available is 2023.3.0 (API 2.9).

Sounds good. I will add the ifdef when the new version of libvpl is released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Fix Non-breaking change which fixes an issue Enhancement Improvement to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants