Use Animated.loop(), when possible, to limit JS thread utilization #204
Conversation
|
Friendly ping. |
createAnimatableComponent.js
Outdated
| animation = Animated.loop(animation, loopConfig); | ||
| } | ||
|
|
||
| animation.start(endState => { | ||
| currentIteration += 1; |
There was a problem hiding this comment.
I'd prefer to rewrite this completely to only use Animated.loop to make it less complicated. For infinite loops you can pass -1 as iterations.
There was a problem hiding this comment.
Correct me if I'm wrong, but I don't think you can support iterationDelay using Animated.loop.
I'd be happy to adjust the code so that single iterations also utilize Animated.loop, and that infinite loops use -1, but I don't think we can entirely eliminate this conditional.
There was a problem hiding this comment.
Hmm, wonder if we can solve this with Animated.delay() instead, but probably not.
There was a problem hiding this comment.
I took a more careful look and it appears that simply applying iterationDelay within the Animated.timing works fine in the context of an Animated.loop.
I've updated the PR and I think you'll find it much more succinct (and thus to your liking).
jamesreggio
force-pushed
the
use-animated-loop-latest
branch
from
170d7ba
to
5b00247
Compare
jamesreggio
force-pushed
the
use-animated-loop-latest
branch
from
5b00247
to
34e3cb7
Compare
|
👍 |
|
@oblador — just in case you didn't see it, I heeded your feedback and simplified the implementation. |
|
Ping, @oblador. |
|
Will this ever land? |
This PR will use
Animated.loop(), when possible, to run looped animations. When combined withuseNativeDriver, this prevents the JS thread from having to kick off each successive loop of an animation, making this library much more suitable for loading spinners and other animations that loop infinitely while the device is under heavy load.If it means anything, I've been using this code in our production app for the past six months with no issue.