NC | nsfs.js | Lower fork_utils dependancy down after process.env.NC_NSFS_NO_DB_ENV=true setting #8164
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the changes
Background:
const { cluster } = require('../util/fork_utils');
dependency before settingprocess.env.NC_NSFS_NO_DB_ENV=true
on nsfs.js.nsfs.js
-> requireforks_utils
-> requiresprometheus_reporting
-> requiresstats_aggregator
-> many files likesystem_store
,bucket_server
etc -> requiresdb_client
-> requirespostgres_client
that setInterval() for VaccumAnalyzer.process.env.NC_NSFS_NO_DB_ENV
isfalse
when requiring forks_utils, we will hit nsfs.js crash after 24 hours.Changes:
process.env.NC_NSFS_NO_DB_ENV=true
we will fail.Issues: Fixed #xxx / Gap #xxx
Testing Instructions:
Manual no code changes -
Manual with setting config/code changes -
Automatic tests -
sudo NC_CORETEST=true node --trace-warnings ./node_modules/mocha/bin/mocha noobaa-core/src/test/unit_tests/test_bucketspace.js