complete upload - skip db access for small object (for performance) #7486
+25
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alphaprinz
force-pushed
the
skip_complete_db_small_obj
branch
from
e7c12f2
to
d8f87a2
Compare
guymguym
requested changes
Sep 10, 2023
alphaprinz
force-pushed
the
skip_complete_db_small_obj
branch
from
9a7810c
to
23919f1
Compare
guymguym
requested changes
Sep 13, 2023
alphaprinz
force-pushed
the
skip_complete_db_small_obj
branch
2 times, most recently
from
b95e540
to
d862801
Compare
alphaprinz
force-pushed
the
skip_complete_db_small_obj
branch
from
d862801
to
a89da1a
Compare
alphaprinz
force-pushed
the
skip_complete_db_small_obj
branch
from
a89da1a
to
604b3d4
Compare
alphaprinz
changed the title
alphaprinz
force-pushed
the
skip_complete_db_small_obj
branch
from
604b3d4
to
dc62bbf
Compare
alphaprinz
force-pushed
the
skip_complete_db_small_obj
branch
from
dc62bbf
to
ba67242
Compare
alphaprinz
force-pushed
the
skip_complete_db_small_obj
branch
2 times, most recently
from
5022402
to
eb39ce8
Compare
|
This PR had no activity for too long - it will now be labeled stale. Update it to prevent it from getting closed. |
|
This PR is stale and had no activity for too long - it will now be closed. |
alphaprinz
force-pushed
the
skip_complete_db_small_obj
branch
from
eb39ce8
to
88d559c
Compare
guymguym
requested changes
Jun 9, 2024
Signed-off-by: Amit Prinz Setter <[email protected]>
Signed-off-by: Amit Prinz Setter <[email protected]>
…nstead of MapServer) Signed-off-by: Amit Prinz Setter <[email protected]>
Signed-off-by: Amit Prinz Setter <[email protected]>
Signed-off-by: Amit Prinz Setter <[email protected]>
Signed-off-by: Amit Prinz Setter <[email protected]>
Signed-off-by: Amit Prinz Setter <[email protected]>
alphaprinz
force-pushed
the
skip_complete_db_small_obj
branch
2 times, most recently
from
5b8edce
to
6345484
Compare
Signed-off-by: Amit Prinz Setter <[email protected]>
alphaprinz
force-pushed
the
skip_complete_db_small_obj
branch
from
6345484
to
c717336
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the changes
For small objects with one part, we know the start/end of object.
There's no need to fix values in db at the end of the put object.
(It's needed for multipart upload where each part doesn't know its start/end at single part upload).
Also, set part as committed when inserting the part (again, to skip db access for removing uncommitted at the end).
Issues: Fixed #xxx / Gap #xxx
Redundant db access at the end of upload.
Testing Instructions: