Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update editor.scss #4737

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Update editor.scss #4737

wants to merge 1 commit into from

Conversation

malee1975
Copy link

  • [ x] Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Proposed changes

It seems to be that when using Chrome and Edge on windows that the scrollbar is always visible until there is an action within the edit dialog. This issue seems to be specific to the configuration dialogs and is more pronounced if a dark theme is used.

Checklist

  • [x ] I have read the contribution guidelines
  • For non-bugfix PRs, I have discussed this change on the forum/slack team.
  • I have run npm run test to verify the unit tests pass
  • I have added suitable unit tests to cover the new/changed functionality

It seems to be that when using Chrome and Edge on windows that the scrollbar is always visible until there is an action within the edit dialog. This issue seems to be specific to the configuration dialogs
Copy link

CLA Not Signed

@knolleary
Copy link
Member

Thanks for this. I'm currently also looking at this one to see if there's a less fragile way of handling the resizing of the form. A lot of this was written before things like flex had wide support... but these days it's a given and might reduce the need for a lot of these 'magic' numbers that can vulnerable to change.

@malee1975
Copy link
Author

I am big fan of flex. I guess ultimately that it would need to be an editor wide implementation of flex.

@knolleary
Copy link
Member

@malee1975 do you see this on all nodes or just some in particular? Which node is in the screenshot you shared in the original issue?

I don't see the scrollbar on Chrome using the default NR theme - I'm wary of making this type of pixel-tweaking change if we can't reproduce generally.

@malee1975
Copy link
Author

malee1975 commented May 30, 2024

All nodes with a configuration dialog, for example this is on Edge:
Screenshot 2024-05-30 135054
And this a different node on Chrome (Version 125.0.6422.113)
Screenshot 2024-05-30 135359
As soon as I input anything into the inputs there is a shift to the right as the scrollbar is removed.
I am on Windows OS version 11.

@knolleary
Copy link
Member

As mentioned, I don't see this on Chrome/MacOS.

@Steve-Mcl as a resident Windows user, could you say if you see this behaviour at all? I'm wary of making these mini-pixel tweaks if they aren't widely reproducable.

@GogoVega
Copy link
Contributor

GogoVega commented Jun 5, 2024

I don't have it on all my config nodes - I deduce that it only affects the dialog box if it has the default size.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants