Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safari: Fix an unexpected input selection #4720

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

GogoVega
Copy link
Contributor

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Proposed changes

Partial fix of #4463.

When double clicking on a node to open the edit box, the palette filter input is selected (blue background). Visible on the video in the linked issue.

It's the same behavior if the double clicking is done in a container (editableList), one of the inputs will be selected.

Checklist

  • I have read the contribution guidelines
  • For non-bugfix PRs, I have discussed this change on the forum/slack team.
  • I have run npm run test to verify the unit tests pass
  • I have added suitable unit tests to cover the new/changed functionality

@@ -40,6 +40,7 @@ body {
position: absolute;
top:40px; left:0; bottom: 0; right:0;
overflow:hidden;
-webkit-user-select: none;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applying this at such a top-level container is risky in terms of side-effects.

I see that Safari still requires the -webkit prefix. I would suggest the first pass should look for all existing instances of user-select and add the -webkit-user-select rule alongside it. That should then mean we have a consistent baseline. Then we can look to see if something additional is needed for Safari.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I look at this 😉

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will convert it to a draft because it will take a little time. i.e. The palette has the disable-selection (user-select for all env) attribute disabled but when I double click on the workspace the filter is selected...

@GogoVega GogoVega marked this pull request as draft May 28, 2024 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants