Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IPV6_PKTINFO, Correct documentationn for IPV6_RECVPKTINFO #2113

Merged
merged 5 commits into from
Jun 27, 2024

Conversation

ishanjain28
Copy link
Contributor

IPV6_PKTINFO was missing from sockopt so I added it and the documentation for IPV6_RECVPKTINFO incorrectly said it was enabling the flag for IPV6_PKTINFO so I corrected that.

Copy link
Member

@SteveLauC SteveLauC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your interest in contributing to Nix, please rebase your branch so that the CI can work (We have migrated from Cirrus to GitHub Action)

src/sys/socket/sockopt.rs Outdated Show resolved Hide resolved
@evanrittenhouse
Copy link

Hi, I need to be able to set this sockopt as well - should I make a new PR? This one seems a bit stale cc @SteveLauC

@SteveLauC
Copy link
Member

Hi, I need to be able to set this sockopt as well - should I make a new PR? This one seems a bit stale cc @SteveLauC

Hi, thanks for your interest in filing a PR for this! Please go ahead:)

@ishanjain28
Copy link
Contributor Author

hey @evanrittenhouse, Can I revive this PR instead? will rebase it today

@ishanjain28
Copy link
Contributor Author

I must be missing some thing. I can not find IPV6_RECVPKTINFO in bsd man pages. Is it still present there and I am looking at the wrong place or do I update the tests ?

src/sys/socket/sockopt.rs Outdated Show resolved Hide resolved
src/sys/socket/sockopt.rs Outdated Show resolved Hide resolved
src/sys/socket/sockopt.rs Outdated Show resolved Hide resolved
src/sys/socket/sockopt.rs Outdated Show resolved Hide resolved
@SteveLauC
Copy link
Member

BTW, a changelog is needed, please see CONTRIBUTING.md on how to add one.

If you apply the changes requested by me, then it should be something similar to:

filename: 2113.added.md

Add socket option `IPV6_PKTINFO` for BSDs/Linux/Android, also `IPV6_RECVPKTINFO` for DragonFlyBSD

Copy link
Member

@SteveLauC SteveLauC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! :)

@SteveLauC SteveLauC enabled auto-merge June 27, 2024 07:15
@SteveLauC SteveLauC added this pull request to the merge queue Jun 27, 2024
Merged via the queue into nix-rust:master with commit 8fedb78 Jun 27, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants