Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow env var to change use-path-style param of s3 config #209

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bestmazzo
Copy link
Contributor

@bestmazzo bestmazzo commented May 13, 2024

Description

As stated in #208 there may be scenarios where s3 storage is configured with a subdomain structure ( ://{bucket_name}.{region}.provider.com ) instead of a path structure ( ://{region}.provider.com/{bucket_name} )
hasura-storage should be able to work accordingly, but we need to extend config params

Problem

So far hasura-storage ENV vars doesn't address this kind of s3 url structure description

Solution

We should see whether passing a ENV_USE_PATH_STYLE variable to s3 config options is enough

cmd/serve.go Outdated Show resolved Hide resolved
cmd/serve.go Outdated Show resolved Hide resolved
@dbarrosop
Copy link
Member

Hi, thanks for the contribution, a couple of minor comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants