Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add: filter persistence #2704

Merged
merged 1 commit into from
Jun 27, 2024
Merged

Conversation

pbek
Copy link
Member

@pbek pbek commented Jun 21, 2024

Summary

Persist the filter state and show unread items by default.

Signed-off-by: Patrizio Bekerle <[email protected]>
@pbek pbek force-pushed the feature/filter-persistence branch from 82dde75 to 60def90 Compare June 21, 2024 17:57
@pbek pbek requested review from Grotax and SMillerDev June 21, 2024 17:57
@Grotax
Copy link
Member

Grotax commented Jun 22, 2024

Hi, maybe I'm too tired but I don't see what this is supposed to do.

I played with this a bit and see no difference in behavior compared to the last alpha.
But that might be related to some cache issue.

So what am I supposed to look for?

@pbek
Copy link
Member Author

pbek commented Jun 22, 2024

It remembers the filter for unread or stared items when you reload the page.

@Grotax
Copy link
Member

Grotax commented Jun 23, 2024

Ah ok, now I got it to work.

Something I noticed, the filter icon should indicate that a filter is active otherwise I already see the issues that the menu on the left does not work.

@Grotax Grotax mentioned this pull request Jun 23, 2024
18 tasks
@pbek
Copy link
Member Author

pbek commented Jun 23, 2024

Which icon do you mean?
When I reload the page, I have the filter icon reflecting that the filter is active...

image

@pbek
Copy link
Member Author

pbek commented Jun 26, 2024

@Grotax, do you need some more information for the PR?

@Grotax
Copy link
Member

Grotax commented Jun 27, 2024

Hi, I mean the filter menu icon.
grafik

Otherwise people will forget that they have a filter set when switching into the different categories on the left main menu.
I will add it to the list of things that should be done.

@Grotax Grotax merged commit 3aae9e3 into nextcloud:master Jun 27, 2024
18 of 21 checks passed
@pbek pbek deleted the feature/filter-persistence branch June 27, 2024 19:45
@pbek
Copy link
Member Author

pbek commented Jun 27, 2024

Ok, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants