Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(bottom-most-compaction): wal apply order #8163

Merged
merged 2 commits into from
Jun 26, 2024

Conversation

skyzh
Copy link
Member

@skyzh skyzh commented Jun 25, 2024

Problem

A follow-up on #8103. Current main branch fails with:

assertion `left == right` failed
  left: b"value 3@0x10@0x30@0x28@0x40"
 right: b"value 3@0x10@0x28@0x30@0x40"

will be fixed after #8103 gets merged.

Summary of changes

Add multiple WALs below GC horizon above base image for key 3

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

@skyzh skyzh requested a review from problame June 25, 2024 19:46
@skyzh skyzh requested a review from a team as a code owner June 25, 2024 19:46
Copy link

github-actions bot commented Jun 25, 2024

2910 tests run: 2794 passed, 0 failed, 116 skipped (full report)


Code coverage* (full report)

  • functions: 32.8% (6891 of 21016 functions)
  • lines: 50.3% (53895 of 107181 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
792183a at 2024-06-26T01:07:22.145Z :recycle:

@skyzh skyzh merged commit 5d2f9ff into main Jun 26, 2024
63 of 64 checks passed
@skyzh skyzh deleted the skyzh/enhanced-compaction-wal-order branch June 26, 2024 13:34
conradludgate pushed a commit that referenced this pull request Jun 27, 2024
A follow-up on #8103.
Previously, main branch fails with:

```
assertion `left == right` failed
  left: b"value 3@0x10@0x30@0x28@0x40"
 right: b"value 3@0x10@0x28@0x30@0x40"
```

This gets fixed after #8103 gets merged.


Signed-off-by: Alex Chi Z <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants