Use cargo-chef for vm-monitor builds #991
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this PR, pg16-disk-test: Clean build took 266s. Rebuilding from main+1 took 201s. With this PR, pg16-disk-test: Clean build took 303s. Rebuilding from main+1 took 101s. (main+1 was jcsp/shard-split-logging; 75747cdbf -> 7f7f33f7e) This is still quite a bit more time to rebuild than I'd like. The final step of building vm-monitor actually takes a surprisingly long time. Also, there's this strange thing where the cargo chef image spends time installing clippy et al during prepare & cook (so, we actually end up doing it twice!). It doesn't take *too* long, but it's worth fixing that before merging, because there's no sense being wasteful.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR, pg16-disk-test:
Clean build took 266s. Rebuilding from main+1 took 201s.
With this PR, pg16-disk-test:
Clean build took 303s. Rebuilding from main+1 took 101s.
(main+1 was jcsp/shard-split-logging; 75747cdbf -> 7f7f33f7e)
This is still quite a bit more time to rebuild than I'd like. The final step of building vm-monitor actually takes a surprisingly long time.
Also, there's this strange thing where the cargo chef image spends time installing clippy et al during prepare & cook (so, we actually end up doing it twice!). It doesn't take too long, but it's worth fixing that before merging, because there's no sense being wasteful.