Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1320: Do not print an error when analysing a lambda function and its associated execution role was previously deleted. #1368

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Tzaoh
Copy link

@Tzaoh Tzaoh commented Oct 5, 2021

Description

Currently, when analysing a lambda function but its associated role execution does not exist, ScoutSuite triggers a NoSuchEntityException exception, printing an error line.

The current change set a condition to check this use case and not printing the corresponding error.

Fixes #1320

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works (optional)
  • New and existing unit tests pass locally with my changes

…its associated execution role was deleted.
@Tzaoh Tzaoh added this to the 5.12 milestone Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants