Ghidra 11.1 required update and adding Drcov additional support #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
June 10, 2024 11:55
|
Also added in a change to the listing/decompiler theme as it was fairly harsh in darkmode - Happy to leave it be though ha 
|
DragonsAshes
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requesting this to be merged in as Cartographer cannot currently be built for Ghidra 11.1 with the removal of the DECOMPILER PluginCategoryNames.
This pull request also includes support for Drcov versions from 2 through 5; based on the lighthouse tool https://github.com/gaasedelen/lighthouse/blob/562595be9bd99e8a5dfef6017d608467f5706630/plugins/lighthouse/reader/parsers/drcov.py#L413
I am curious why the base is required when Ghidra sets it to 0? I had to change the base to 0 for drcov v2 to have the log files load properly - perhaps this is required for all Drcov versions? Happy to make the change to the pull request.