Refactoring of the Dockerfile #654
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Bump Python version 3.9 -> 3.12
* Add ability to specify Python version as build argument
* Use a 2-stage-build with virtual environment
* Build in stage 0
* Execute in stage 1
* Do not call setup.py anymore, instead use pip install
* Remove installation of sudo which seems to do nothing
* Add .git folder to .dockerignore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will change up the Dockerfile a bit. The most important changes can be summarized as:
Considering that Python 3.9 is EOL next year's October I changed the default Python version to 3.12. Another version can simply be set when building with the "--build-arg" parameter like "--build-arg PYTHON_VERSION='3.11'" to use Python 3.11.
The usage of the venv and adding it to PATH eliminates the need to call sslyze with "python -m sslyze" and lets you call it directly with just "sslyze".