-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(editor): Migrate NodeDetailsView.vue
to use script setup (no-changelog)
#9762
Conversation
NodeDetailsView.vue
to composition API onlyNodeDetailsView.vue
to use script setup (no-changelog)
|
2 flaky tests on run #5506 ↗︎
Details:
5-ndv.cy.ts • 1 flaky test
10-undo-redo.cy.ts • 1 flaky test
Review all test suite changes for PR #9762 ↗︎ |
✅ All Cypress E2E specs passed |
renaming: { | ||
type: Boolean, | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since required
is false
by default in the old style, this should have been converted to
const props = withDefaults(
defineProps<{
readOnly?: boolean;
renaming?: boolean;
isProductionExecutionPreview?: boolean;
}>(),
{
isProductionExecutionPreview: false,
},
);
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch! Addressed it here. Thanks.
Got released with |
1 similar comment
Got released with |
Summary
Title self explanatory
Review / Merge checklist