refactor(core): Make PruningService.init and WaitTracker.init consistent (no-changelog)
#9761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sistent (no-changelog)
n8n-assistant
bot
added
core
krynble
reviewed
Jun 17, 2024
| @@ -199,7 +199,10 @@ export class Start extends BaseCommand { | |||
| } | |||
|
|
|||
| async initOrchestration() { | |||
| if (config.getEnv('executions.mode') !== 'queue') return; | |||
| if (config.getEnv('executions.mode') === 'regular') { | |||
There was a problem hiding this comment.
I love this change, I think it makes more sense and can streamline a few things
krynble
approved these changes
Jun 17, 2024
5 flaky tests on run #5511 ↗︎
Details:
|
|||||||||||||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| NDV > should not retrieve remote options when required params throw errors |
Screenshots
Video
|
|
| NDV > Stop listening for trigger event from NDV |
Screenshots
Video
|
|
10-undo-redo.cy.ts • 2 flaky tests
| Test | Artifacts | |
|---|---|---|
| Undo/Redo > should undo/redo adding nodes |
Test Replay
Screenshots
Video
|
|
| Undo/Redo > should undo/redo adding connected nodes |
Test Replay
Screenshots
Video
|
|
24-ndv-paired-item.cy.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| NDV > resolves expression with default item when input node is not parent, while still pairing items |
Test Replay
Screenshots
Video
|
|
Review all test suite changes for PR #9761 ↗︎
|
✅ All Cypress E2E specs passed |
adrian-martinez-onestic
pushed a commit
to onesdata/n8n-fork
that referenced
this pull request
Jun 20, 2024
…sistent (no-changelog) (n8n-io#9761)
adrian-martinez-onestic
pushed a commit
to onesdata/n8n-fork
that referenced
this pull request
Jun 20, 2024
…sistent (no-changelog) (n8n-io#9761)
|
Got released with |
1 similar comment
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed with @krynble