Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(core): Remove unused execution status warning (no-changelog) #9759

Merged
merged 2 commits into from
Jun 17, 2024
Merged

refactor(core): Remove unused execution status warning (no-changelog) #9759

merged 2 commits into from
Jun 17, 2024

Conversation

ivov
Copy link
Contributor

@ivov ivov commented Jun 14, 2024

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Jun 14, 2024
ivov
ivov commented Jun 17, 2024
View reviewed changes
packages/cli/src/types/commands.types.ts
@@ -36,7 +36,7 @@ interface IExecutionError {

export interface IWorkflowExecutionProgress {
workflowId: string;
status: ExecutionStatus;
status: ExecutionStatus | 'warning';
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here only used for reporting, not persisted.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we should use another type, extend IWorkflowExecutionProgress to something like CliExecutionResult that could contain warning as one of the status, how does it sound? Maybe outside of the scope of this PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree, for now I'll keep this PR about simplifying ExecutionStatus. Let's refine types for CLI commands in future.

krynble
krynble approved these changes Jun 17, 2024
View reviewed changes
packages/cli/src/types/commands.types.ts
@@ -36,7 +36,7 @@ interface IExecutionError {

export interface IWorkflowExecutionProgress {
workflowId: string;
status: ExecutionStatus;
status: ExecutionStatus | 'warning';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we should use another type, extend IWorkflowExecutionProgress to something like CliExecutionResult that could contain warning as one of the status, how does it sound? Maybe outside of the scope of this PR.

@github-actions GitHub Actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@cypress Cypress
Copy link

cypress bot commented Jun 17, 2024

4 flaky tests on run #5513 ↗︎

0 393 0 0 Flakiness 4

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 ivov 🗃️ e2e/*
Project: n8n Commit: 83294ba4d5
Status: Passed Duration: 04:48 💡
Started: Jun 17, 2024 10:54 AM Ended: Jun 17, 2024 10:59 AM
Flakiness  5-ndv.cy.ts • 2 flaky tests

View Output Video

Test Artifacts
NDV > should not retrieve remote options when required params throw errors Screenshots Video
NDV > Stop listening for trigger event from NDV Screenshots Video
Flakiness  10-undo-redo.cy.ts • 1 flaky test

View Output Video

Test Artifacts
Undo/Redo > should undo/redo adding connected nodes Test Replay Screenshots Video
Flakiness  20-workflow-executions.cy.ts • 1 flaky test

View Output Video

Test Artifacts
Current Workflow Executions > should auto load more items if there is space and auto scroll Test Replay Screenshots Video

Review all test suite changes for PR #9759 ↗︎

@ivov ivov merged commit d615711 into master Jun 17, 2024
31 checks passed
@ivov ivov deleted the remove-unused-execution-status-warning branch June 17, 2024 11:00
adrian-martinez-onestic pushed a commit to onesdata/n8n-fork that referenced this pull request Jun 20, 2024
@ivov @adrian-martinez-onestic
refactor(core): Remove unused execution status warning (no-changelo…
1302911 
…g) (n8n-io#9759)
adrian-martinez-onestic pushed a commit to onesdata/n8n-fork that referenced this pull request Jun 20, 2024
@ivov @adrian-martinez-onestic
refactor(core): Remove unused execution status warning (no-changelo…
b87c9ab 
…g) (n8n-io#9759)
@janober
Copy link
Member

janober commented Jun 20, 2024

Got released with [email protected]

1 similar comment
@janober
Copy link
Member

janober commented Jun 20, 2024

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krynble krynble krynble approved these changes

Assignees
No one assigned
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ivov @janober @krynble