refactor(editor): Migrate BreakpointsObserver component to Vue 3 syntax (no-changelog)
#9758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntax (no-changelog) Signed-off-by: Oleg Ivaniv <[email protected]>
n8n-assistant
bot
added
n8n team
alexgrozav
previously approved these changes
Jun 18, 2024
| return this.valueSM; | ||
| } | ||
| const bannerHeight = await getBannerRowHeight(); | ||
| useUIStore().updateBannersHeight(bannerHeight); |
There was a problem hiding this comment.
Maybe we could have the uiStore initialized at root level to no longer make this function call every time we resize?
There was a problem hiding this comment.
Fair point, updated
Signed-off-by: Oleg Ivaniv <[email protected]>
alexgrozav
approved these changes
Jun 18, 2024
|
✅ No visual regressions found. |
3 flaky tests on run #5540 ↗︎
Details:
|
||||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| NDV > should not retrieve remote options when required params throw errors |
Screenshots
Video
|
|
| NDV > Stop listening for trigger event from NDV |
Screenshots
Video
|
|
12-canvas.cy.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| Canvas Node Manipulation and Navigation > should preserve connections after rename & node-view switch |
Test Replay
Screenshots
Video
|
|
Review all test suite changes for PR #9758 ↗︎
|
✅ All Cypress E2E specs passed |
adrian-martinez-onestic
pushed a commit
to onesdata/n8n-fork
that referenced
this pull request
Jun 20, 2024
…ntax (no-changelog) (n8n-io#9758) Signed-off-by: Oleg Ivaniv <[email protected]>
adrian-martinez-onestic
pushed a commit
to onesdata/n8n-fork
that referenced
this pull request
Jun 20, 2024
…ntax (no-changelog) (n8n-io#9758) Signed-off-by: Oleg Ivaniv <[email protected]>
|
Got released with |
1 similar comment
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related Linear tickets, Github issues, and Community forum posts
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)