-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(editor): Refactor code editors to composition API (no-changelog) #9757
Conversation
|
4 flaky tests on run #5600 ↗︎Details:
|
Test | Artifacts | |
---|---|---|
NDV > should not retrieve remote options when required params throw errors |
Screenshots
Video
|
|
NDV > Stop listening for trigger event from NDV |
Screenshots
Video
|
10-undo-redo.cy.ts • 2 flaky tests
Test | Artifacts | |
---|---|---|
Undo/Redo > should undo/redo adding nodes |
Test Replay
Screenshots
Video
|
|
Undo/Redo > should undo/redo adding connected nodes |
Test Replay
Screenshots
Video
|
Review all test suite changes for PR #9757 ↗︎
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this is messing with the ask-ai feature in the code node editor.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤞🏽
✅ All Cypress E2E specs passed |
* 'master' of github.com:n8n-io/n8n: (380 commits) feat(Anthropic Chat Model Node): Add support for Claude 3.5 Sonnet (n8n-io#9832) refactor(core): Remove inferral of execution status (no-changelog) (n8n-io#9829) refactor(core): Log denials from subworkflow caller policy (no-changelog) (n8n-io#9827) fix(Zulip Node): Fix a typo preventing some messages from updating (n8n-io#7078) 🚀 Release 1.47.0 (n8n-io#9826) ci: Fix repository url for provenance checks (no-changelog) (n8n-io#9825) docs: Update docs links in the HTTP node (no-changelog) (n8n-io#9188) feat(Pipedrive Node): Add sort field for get all persons (n8n-io#8138) ci: Add opencontainer image spec labels to the release Dockerfile (no-changelog) (n8n-io#9822) fix(core): Upgrade `ws` to address CVE-2024-37890 (n8n-io#9801) ci: Fix ARM custom images (no-changelog) (n8n-io#9821) fix: Get workflow not returning home project and shared projects (no-changelog) (n8n-io#9815) fix(AWS SES Node): Fix issue with email aliases not working for sending from or sending to (n8n-io#9811) fix(Google Sheets Node): Check for column names changes before upsert, append, update (n8n-io#9649) fix(MongoDB Node): Correct typo in MongoDbProperties (no-changelog) (n8n-io#9587) fix(editor): Console error in ActionsMode when searching for action and pressing enter (no-changelog) (n8n-io#9292) fix(Airtable Node): Make multipleRecordLinks editable in fields (n8n-io#9608) refactor(editor): Refactor code editors to composition API (no-changelog) (n8n-io#9757) refactor: Correct spelling mistakes (no-changelog) (n8n-io#9305) fix(editor): Align all cell contents to the top in RunDataTable (no-changelog) (n8n-io#3889) ...
* n8n-io-master: (380 commits) feat(Anthropic Chat Model Node): Add support for Claude 3.5 Sonnet (n8n-io#9832) refactor(core): Remove inferral of execution status (no-changelog) (n8n-io#9829) refactor(core): Log denials from subworkflow caller policy (no-changelog) (n8n-io#9827) fix(Zulip Node): Fix a typo preventing some messages from updating (n8n-io#7078) 🚀 Release 1.47.0 (n8n-io#9826) ci: Fix repository url for provenance checks (no-changelog) (n8n-io#9825) docs: Update docs links in the HTTP node (no-changelog) (n8n-io#9188) feat(Pipedrive Node): Add sort field for get all persons (n8n-io#8138) ci: Add opencontainer image spec labels to the release Dockerfile (no-changelog) (n8n-io#9822) fix(core): Upgrade `ws` to address CVE-2024-37890 (n8n-io#9801) ci: Fix ARM custom images (no-changelog) (n8n-io#9821) fix: Get workflow not returning home project and shared projects (no-changelog) (n8n-io#9815) fix(AWS SES Node): Fix issue with email aliases not working for sending from or sending to (n8n-io#9811) fix(Google Sheets Node): Check for column names changes before upsert, append, update (n8n-io#9649) fix(MongoDB Node): Correct typo in MongoDbProperties (no-changelog) (n8n-io#9587) fix(editor): Console error in ActionsMode when searching for action and pressing enter (no-changelog) (n8n-io#9292) fix(Airtable Node): Make multipleRecordLinks editable in fields (n8n-io#9608) refactor(editor): Refactor code editors to composition API (no-changelog) (n8n-io#9757) refactor: Correct spelling mistakes (no-changelog) (n8n-io#9305) fix(editor): Align all cell contents to the top in RunDataTable (no-changelog) (n8n-io#3889) ...
Summary
Refactor code editors to composition API
Code editor linter did not update when user changes the mode (once for each vs for all), fixed reactivity
Review / Merge checklist
release/backport
(if the PR is an urgent fix that needs to be backported)