refactor: Migrate Select to composition API (no-changelog)
#9750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomi
commented
Jun 14, 2024
Comment on lines
+71
to
+90
| const focus = () => { | ||
| innerSelect.value?.focus(); | ||
| }; | ||
|
|
||
| const blur = () => { | ||
| innerSelect.value?.blur(); | ||
| }; | ||
|
|
||
| const focusOnInput = () => { | ||
| if (!innerSelect.value) return; | ||
|
|
||
| const inputRef = innerSelect.value.$refs.input as HTMLInputElement | undefined; | ||
| inputRef?.focus(); | ||
| }; | ||
|
|
||
| defineExpose({ | ||
| focus, | ||
| blur, | ||
| focusOnInput, | ||
| }); |
There was a problem hiding this comment.
I assume these were exposed as they were not used internally
tomi
changed the title
tomi
force-pushed
the
migrate-select-to-composition-api
branch
from
3bafcca
to
59c259a
Compare
n8n-assistant
bot
added
n8n team
tomi
changed the title
Select to composition API (no-changelog)
cstuncsik
approved these changes
Jun 17, 2024
|
|
3 flaky tests on run #5498 ↗︎
Details:
|
||||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Undo/Redo > should undo/redo adding nodes |
Test Replay
Screenshots
Video
|
|
| Undo/Redo > should undo/redo adding connected nodes |
Test Replay
Screenshots
Video
|
|
5-ndv.cy.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| NDV > should not retrieve remote options when required params throw errors |
Screenshots
Video
|
|
Review all test suite changes for PR #9750 ↗︎
|
✅ All Cypress E2E specs passed |
adrian-martinez-onestic
pushed a commit
to onesdata/n8n-fork
that referenced
this pull request
Jun 20, 2024
adrian-martinez-onestic
pushed a commit
to onesdata/n8n-fork
that referenced
this pull request
Jun 20, 2024
|
Got released with |
1 similar comment
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Migrate Select to composition API
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)