refactor: Refactor input components to composition API (no-changelog) #9744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
n8n team
alexgrozav
requested changes
Jun 14, 2024
packages/editor-ui/src/components/CredentialEdit/CredentialInputs.vue
Outdated
Show resolved
Hide resolved
packages/editor-ui/src/components/ExpandableInput/ExpandableInputEdit.vue
Outdated
Show resolved
Hide resolved
| @@ -105,13 +105,13 @@ const rightParameter = computed<INodeProperties>(() => { | |||
|
|
|||
| const debouncedEmitUpdate = debounce(() => emit('update', condition.value), { debounceTime: 500 }); | |||
|
|
|||
| const onLeftValueChange = (update: IUpdateInformation<NodeParameterValue>): void => { | |||
There was a problem hiding this comment.
Wouldn't leaving the generic here avoid casting as NodeParameterValue?
There was a problem hiding this comment.
I typed the emit that this function listens to with IUpdateInformation, so leaving the generic gives an error
|
|
2 flaky tests on run #5553 ↗︎
Details:
|
|||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| NDV > should not retrieve remote options when required params throw errors |
Screenshots
Video
|
|
17-sharing.cy.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| Credential Usage in Cross Shared Workflows > should only show credentials in their personal project for members |
Test Replay
Screenshots
Video
|
|
Review all test suite changes for PR #9744 ↗︎
alexgrozav
approved these changes
Jun 18, 2024
|
✅ No visual regressions found. |
|
|
|
✅ All Cypress E2E specs passed |
adrian-martinez-onestic
pushed a commit
to onesdata/n8n-fork
that referenced
this pull request
Jun 20, 2024
adrian-martinez-onestic
pushed a commit
to onesdata/n8n-fork
that referenced
this pull request
Jun 20, 2024
|
Got released with |
1 similar comment
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Refactor input components to composition API
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)