Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(editor): Translate sidebar "Help" label (no-changelog) #9732

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

TaylorHo
Copy link
Contributor

Summary

This PR translates one more item from the Main Sidebar, the "Help" label. It was in hard-coded English, but the "Help" item for the sidebar is in the translations file, so it was changed to make It ready for future translations (when n8n supports it broadly).

Related Linear tickets, Github issues, and Community forum posts

No, I struggled with it in personal translations and thought it would be nice to be translation-ready.

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@CLAassistant
Copy link

CLAassistant commented Jun 13, 2024

CLA assistant check
All committers have signed the CLA.

@n8n-assistant n8n-assistant bot added community Authored by a community member ui Enhancement in /editor-ui or /design-system in linear Issue or PR has been created in Linear for internal review labels Jun 13, 2024
Copy link
Member

@netroy netroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this 🙏🏽

@netroy netroy changed the title refactor(editor): Translate sidebar "Help" label refactor(editor): Translate sidebar "Help" label (no-changelog) Jun 19, 2024
@netroy netroy merged commit 4740162 into n8n-io:master Jun 19, 2024
9 checks passed
Copy link

cypress bot commented Jun 20, 2024

3 flaky tests on run #5597 ↗︎

0 395 0 0 Flakiness 3

Details:

🌳 master 🖥️ browsers:node18.12.0-chrome107 🤖 PR User 🗃️ e2e/*
Project: n8n Commit: 4740162232
Status: Passed Duration: 04:49 💡
Started: Jun 20, 2024 3:11 AM Ended: Jun 20, 2024 3:16 AM
Flakiness  5-ndv.cy.ts • 2 flaky tests

View Output Video

Test Artifacts
NDV > should not retrieve remote options when required params throw errors Screenshots Video
NDV > Stop listening for trigger event from NDV Screenshots Video
Flakiness  10-undo-redo.cy.ts • 1 flaky test

View Output Video

Test Artifacts
Undo/Redo > should undo/redo adding connected nodes Test Replay Screenshots Video

Review all test suite changes for PR #9732 ↗︎

@janober
Copy link
Member

janober commented Jun 20, 2024

Got released with [email protected]

1 similar comment
@janober
Copy link
Member

janober commented Jun 20, 2024

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Authored by a community member in linear Issue or PR has been created in Linear for internal review ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants