feat: docker images for iroh #2404
Open
+183
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arqu
commented
Jun 24, 2024
Dockerfile
Outdated
| # USER nonroot | ||
| # expose the default ports | ||
| EXPOSE 4433 8000 9090 | ||
| ENTRYPOINT ["./iroh start"] |
There was a problem hiding this comment.
Adjust this line for alternate configs or start cmds.
|
@Arqu once we merge this, can we automate it, to publish this to dockerhub on release? |
Dockerfile
Outdated
| RUN cargo build --bin iroh --release --all-features | ||
|
|
||
| ### Final Image | ||
| FROM ubuntu:latest as iroh |
There was a problem hiding this comment.
can we switch this to alpine?
There was a problem hiding this comment.
or sth else that is smaller
dignifiedquire
force-pushed
the
arqu/docker
branch
from
a6ff3e3
to
4b01a61
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Breaking Changes
Notes & open questions
Change checklist