Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs][material-ui][Select] Fix the SelectAutoWidth demo menu item value #42648

Merged
merged 3 commits into from
Jun 20, 2024

Conversation

Danielkhakbaz
Copy link
Contributor

One of the value of the select component was set to 10 while the text that was getting shown was 20.

@mui-bot
Copy link

mui-bot commented Jun 15, 2024

Netlify deploy preview

https://deploy-preview-42648--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 654d10c

sai6855

This comment was marked as outdated.

Copy link
Contributor

@sai6855 sai6855 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Danielkhakbaz run pnpm docs:typescript:formatted and commit changes to fix CI

@sai6855 sai6855 added docs Improvements or additions to the documentation component: select This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material labels Jun 16, 2024
@danilo-leal danilo-leal changed the title Fix one of the value of the SelectAutoWidth component [material-ui][docs] Fix the SelectAutoWidth demo menu item value Jun 19, 2024
@ZeeshanTamboli ZeeshanTamboli changed the title [material-ui][docs] Fix the SelectAutoWidth demo menu item value [docs][material-ui] Fix the SelectAutoWidth demo menu item value Jun 20, 2024
@ZeeshanTamboli ZeeshanTamboli changed the title [docs][material-ui] Fix the SelectAutoWidth demo menu item value [docs][material-ui][Select] Fix the SelectAutoWidth demo menu item value Jun 20, 2024
@ZeeshanTamboli ZeeshanTamboli added bug 🐛 Something doesn't work needs cherry-pick The PR should be cherry-picked to master after merge labels Jun 20, 2024
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@ZeeshanTamboli ZeeshanTamboli merged commit 9476434 into mui:next Jun 20, 2024
19 checks passed
github-actions bot pushed a commit that referenced this pull request Jun 20, 2024
…value (#42648)

Signed-off-by: Daniel Khakbaz <[email protected]>
Co-authored-by: ZeeshanTamboli <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: select This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation needs cherry-pick The PR should be cherry-picked to master after merge package: material-ui Specific to @mui/material
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants