User set ignored subs during embedded detection #2494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carrow8993
force-pushed
the
user-ignore-embed-subs
branch
from
ad334c4
to
f7c271c
Compare
bazarr/subtitles/indexer/series.py
Outdated
Comment on lines
44
to
50
| skip_flag = False | ||
| for sub_codec in settings.general.ignored_subs: | ||
| if subtitle_codec.lower() == sub_codec: | ||
| skip_flag = True | ||
| logging.debug("BAZARR skipping %s sub for language: %s" % (subtitle_codec, alpha2_from_alpha3(subtitle_language))) | ||
| break | ||
| if skip_flag: continue |
There was a problem hiding this comment.
I would say we could use some refactoring here to completely skip this boolean like:
if any(subtitle_codec.lower() == sub_codec for sub_codec in settings.general.ignored_subs):
logging.debug(f"BAZARR skipping {subtitle_codec} sub for language: {alpha2_from_alpha3(subtitle_language)}")
continue
Similar comment also applies to the movies indexer.
There was a problem hiding this comment.
I think I did the rebase/merge/refactor appropriately? I'm sorry, I'm still quite new to this and I managed to break my dev environment so I couldn't do a proper test before heading out of town shortly here.
…encoding may be using a different UTF8 normalization form.
* Use Hamming textdistance library Used Hamming textdistance to sort by closest match. * Global search UI improvements Increased dropdown height to show more results initially (and which can also be scrolled into view). Scrollbars will appear automatically as needed. Remove dropdown when Search box is cleared. * Added textdistance 4.6.2 library
…65535#2509 * fix: quotes surround series name not season * feat: Add search via series imdb id * chore: Add comment * fix: Last small fixes
* chore: Bump pysubs2 to v1.7.1 * chore: bump version to 1.7.2 * remove bin
…pheus65535#2507) Bumps [react-router-dom](https://github.com/remix-run/react-router/tree/HEAD/packages/react-router-dom) from 6.22.3 to 6.23.1. - [Release notes](https://github.com/remix-run/react-router/releases) - [Changelog](https://github.com/remix-run/react-router/blob/main/packages/react-router-dom/CHANGELOG.md) - [Commits](https://github.com/remix-run/react-router/commits/[email protected]/packages/react-router-dom) --- updated-dependencies: - dependency-name: react-router-dom dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Fixed action icon styles * small fixes * fix brand color * more small fixes * fix disabled color for dark * feat: customize highlight and warning badge * chore: Remove hardcoded variables * feat: add text wrap pretty to pop over * fix: pagination position * chore: small adjustments
Bumps the fortawesome group in /frontend with 1 update: [@fortawesome/react-fontawesome](https://github.com/FortAwesome/react-fontawesome). Updates `@fortawesome/react-fontawesome` from 0.2.0 to 0.2.2 - [Release notes](https://github.com/FortAwesome/react-fontawesome/releases) - [Changelog](https://github.com/FortAwesome/react-fontawesome/blob/0.2.x/CHANGELOG.md) - [Commits](FortAwesome/react-fontawesome@0.2.0...0.2.2) --- updated-dependencies: - dependency-name: "@fortawesome/react-fontawesome" dependency-type: direct:development update-type: version-update:semver-patch dependency-group: fortawesome ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Fixed mass edit language missing clear * Fixed mass edit profile clear * chore: Remove unused attributes
…operly reintroduced later.
…n-HI only feature.
…5535#2543) Bumps the mantine group in /frontend with 6 updates: | Package | From | To | | --- | --- | --- | | [@mantine/core](https://github.com/mantinedev/mantine/tree/HEAD/packages/@mantine/core) | `7.10.1` | `7.10.2` | | [@mantine/dropzone](https://github.com/mantinedev/mantine/tree/HEAD/packages/@mantine/dropzone) | `7.10.1` | `7.10.2` | | [@mantine/form](https://github.com/mantinedev/mantine/tree/HEAD/packages/@mantine/form) | `7.10.1` | `7.10.2` | | [@mantine/hooks](https://github.com/mantinedev/mantine/tree/HEAD/packages/@mantine/hooks) | `7.10.1` | `7.10.2` | | [@mantine/modals](https://github.com/mantinedev/mantine/tree/HEAD/packages/@mantine/modals) | `7.10.1` | `7.10.2` | | [@mantine/notifications](https://github.com/mantinedev/mantine/tree/HEAD/packages/@mantine/notifications) | `7.10.1` | `7.10.2` | Updates `@mantine/core` from 7.10.1 to 7.10.2 - [Release notes](https://github.com/mantinedev/mantine/releases) - [Changelog](https://github.com/mantinedev/mantine/blob/master/CHANGELOG.md) - [Commits](https://github.com/mantinedev/mantine/commits/7.10.2/packages/@mantine/core) Updates `@mantine/dropzone` from 7.10.1 to 7.10.2 - [Release notes](https://github.com/mantinedev/mantine/releases) - [Changelog](https://github.com/mantinedev/mantine/blob/master/CHANGELOG.md) - [Commits](https://github.com/mantinedev/mantine/commits/7.10.2/packages/@mantine/dropzone) Updates `@mantine/form` from 7.10.1 to 7.10.2 - [Release notes](https://github.com/mantinedev/mantine/releases) - [Changelog](https://github.com/mantinedev/mantine/blob/master/CHANGELOG.md) - [Commits](https://github.com/mantinedev/mantine/commits/7.10.2/packages/@mantine/form) Updates `@mantine/hooks` from 7.10.1 to 7.10.2 - [Release notes](https://github.com/mantinedev/mantine/releases) - [Changelog](https://github.com/mantinedev/mantine/blob/master/CHANGELOG.md) - [Commits](https://github.com/mantinedev/mantine/commits/7.10.2/packages/@mantine/hooks) Updates `@mantine/modals` from 7.10.1 to 7.10.2 - [Release notes](https://github.com/mantinedev/mantine/releases) - [Changelog](https://github.com/mantinedev/mantine/blob/master/CHANGELOG.md) - [Commits](https://github.com/mantinedev/mantine/commits/7.10.2/packages/@mantine/modals) Updates `@mantine/notifications` from 7.10.1 to 7.10.2 - [Release notes](https://github.com/mantinedev/mantine/releases) - [Changelog](https://github.com/mantinedev/mantine/blob/master/CHANGELOG.md) - [Commits](https://github.com/mantinedev/mantine/commits/7.10.2/packages/@mantine/notifications) --- updated-dependencies: - dependency-name: "@mantine/core" dependency-type: direct:production update-type: version-update:semver-patch dependency-group: mantine - dependency-name: "@mantine/dropzone" dependency-type: direct:production update-type: version-update:semver-patch dependency-group: mantine - dependency-name: "@mantine/form" dependency-type: direct:production update-type: version-update:semver-patch dependency-group: mantine - dependency-name: "@mantine/hooks" dependency-type: direct:production update-type: version-update:semver-patch dependency-group: mantine - dependency-name: "@mantine/modals" dependency-type: direct:production update-type: version-update:semver-patch dependency-group: mantine - dependency-name: "@mantine/notifications" dependency-type: direct:production update-type: version-update:semver-patch dependency-group: mantine ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…rver returned http 500.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements a chips dialogue input on the Settings > Subtitles page that allows the user to input their choice of codecs to ignore during embedded sub detection. This is saved to a list as ignored_subs in general settings. Updates indexer logic for both series and movies to check this list during embedded sub check.