-
Notifications
You must be signed in to change notification settings - Fork 542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support YUV 4:4:4 streaming #1282
base: master
Are you sure you want to change the base?
Conversation
cea3332
to
b95eb0a
Compare
@cgutman I probably can't do more on moonlight side (moonlight-common-c included) without feedback. Format selection logic appears overcomplicated to me, so I've probably missed some corner cases, and you might prefer to do some things differently altogether. Also if you prefer, you can simply take this over after 5.1 is released, this may prevent the needless back-and-forth. |
|
Hi @ns6089, this development is planned to be developed on moonlight-android? |
Not anytime soon, no hardware support. |
27086f4
to
16e80a7
Compare
|
Keep it up! Looking forward to the success of YUV444!! For high-end computer users and those with WiFi 6 or above, we hope for higher bitrate requests and better picture encoding and transmission. |
I have obtained the version you uploaded on AppVeyor, and I know that this requires support for synchronous encoding by Sunshine, which is not currently in effect. What I want to point out is that when I enable the 444 button, my bitrate can only go up to 114mbps. If 444 is implemented, it shouldn't be limited to this range, right? |
|
@ns6089 Thank you for your work ! |
The repository with binary dependencies needs to be updated, I'm trying to get this sorted out. |
Can't be done before 6.0.1 hotfix goes live it seems. |
Even recovering v6 it doesn't build? |
If you're trying to build outside of CI on your own computer, this PR currently contains commits that revert binary deps to somewhat functional state. But you also need local vulkan headers, with %VULKAN_SDK% env variable pointing at them. installing SDK from https://vulkan.lunarg.com/sdk/home#windows should be enough. |
Add support for YUV 4:4:4 streaming
moonlight-common-c pull request: moonlight-stream/moonlight-common-c#91 merged
sunshine pull request: LizardByte/Sunshine#2533 draft
Todo, in no particular order:
VK_COLOR_SPACE_HDR10_ST2084_EXT
and it fails when display is not in HDR mode