Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for themes #1554

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

xTudoS
Copy link
Contributor

@xTudoS xTudoS commented Jun 2, 2024

This change is Reviewable


add back support for themes thanks to https://github.com/vadimdemedes/thememirror

Fix #1549

@xTudoS
Copy link
Contributor Author

xTudoS commented Jun 2, 2024

@shakaran @rtritto one of you guys mind in review this PR please?

@rtritto
Copy link
Member

rtritto commented Jun 2, 2024

@xTudoS the dark theme component should be removed if ME_CONFIG_OPTIONS_EDITORTHEME env var isn't empty.

The theme logic doesn't work, I did some try such as ME_CONFIG_OPTIONS_EDITORTHEME="espresso" or ME_CONFIG_OPTIONS_EDITORTHEME="oneDark".

@xTudoS
Copy link
Contributor Author

xTudoS commented Jun 2, 2024

@xTudoS the dark theme component should be removed if ME_CONFIG_OPTIONS_EDITORTHEME env var isn't empty.

The theme logic doesn't work, I did some try such as ME_CONFIG_OPTIONS_EDITORTHEME="espresso" or ME_CONFIG_OPTIONS_EDITORTHEME="oneDark".

thanks for reviewing
I will check

@xTudoS
Copy link
Contributor Author

xTudoS commented Jun 2, 2024

@rtritto I decide to keep theme mode toggle because there are dark and light editor themes, just imagine choosing a dark theme for codemirror but the entire application is in light mode.

@rtritto rtritto added the feature label Jun 7, 2024
@rtritto rtritto changed the title add support for themes again feat: add support for themes again Jun 7, 2024
@rtritto rtritto changed the title feat: add support for themes again feat: add support for themes Jun 7, 2024
@xTudoS
Copy link
Contributor Author

xTudoS commented Jun 27, 2024

@rtritto would you validate this again please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve cursor contrast in Dark Mode
2 participants