Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: local assets path on loading mongo-express as middleware #1534

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

royalgarter
Copy link

@royalgarter royalgarter commented May 6, 2024

This change is Reviewable


  • Add support for apply local assets path from config

- Add support for apply local assets path from config
@rtritto
Copy link
Member

rtritto commented May 6, 2024

Should we handle the asset path as environment variable instead of use config.locals.assets?

@royalgarter
Copy link
Author

Should we handle the asset path as environment variable instead of use config.locals.assets?

Yes, i think we can support both ways.

@rtritto rtritto force-pushed the pr-02 branch 2 times, most recently from d461b0a to 71d8f89 Compare June 7, 2024 18:13
@rtritto
Copy link
Member

rtritto commented Jun 7, 2024

@royalgarter please can you review?

@rtritto rtritto added the bug label Jun 7, 2024
@rtritto rtritto changed the title Fix minor bug local assets path when loading mongo-express as middleware fix: local assets path on loading mongo-express as middleware Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants