-
Notifications
You must be signed in to change notification settings - Fork 939
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use generic package manager #1533
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a question. There will be no need to add a package-lock.json or a something similar to that to keep packages versions synced?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I should use (prefer) yarn
as main package manager because it use some fields in package.json and has some additional files.
To sync (freeze) dependencies we can use yarn.lock
. Imo maintain the package-lock.json
too isn't needed.
At install step, each package manager removes files of other package managers and creates files that it needs.
@BlackthornYugen what do you think about this changes? |
I'm not familiar with the cross-env, but I would agree that package locks are required so that we can have reproducible builds. |
So we must maintain and update both We need some ideas 🤔 Imo this feature can be merged and the maintain lock files will be handled in another feature. P.S.: next we can also add the |
For the feature that update (handle) lock files, I created this WIP https://github.com/mongo-express/mongo-express/tree/update-lock-files Can anyone review this PR? |
- For better compatible with project using npm only - Tested with node 18/20/22 (npm 10+)
This change is![Reviewable](https://camo.githubusercontent.com/23b05f5fb48215c989e92cc44cf6512512d083132bd3daf689867c8d9d386888/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)
- For better compatible with project using npm only- Tested with node 18/20/22 (npm 10+)Add support to package managers (not only
yarn
ornpm
):yarn
npm
pnpm
etc)TODO:
Fix #1543