[stdlib] add __str__ and __repr__ for Optional
#3061
Conversation
bgreni
force-pushed
the
optional-str-repr
branch
from
288fe4d
to
58d9f56
Compare
bgreni
changed the title
__str__ and __repr__ for Optional
bgreni
force-pushed
the
optional-str-repr
branch
from
58d9f56
to
9306141
Compare
stdlib/src/collections/optional.mojo
Outdated
| writer: The formatter to write to. | ||
| """ | ||
| if self: | ||
| write_to(writer, repr(self.value())) |
There was a problem hiding this comment.
Here repr(self.value()) can be a very big String. If we know that self.value() has a format_to method, would it be possible to use it to write directly to the Formatter?
You can imagine that self.value() is a List with 10 000 elements for example.
There was a problem hiding this comment.
I like the idea, but wouldn't that require use to generally shift away from RepresentableCollectionElement in these scenarios to something equivalent to Formattable & CollectionElement?
There was a problem hiding this comment.
I agree with Gabriel that we could make this more efficient, though we can do that in a follow-up PR if you'd like 🙂
There was a problem hiding this comment.
Might as well do it here. I'm on vacation at the moment but I can look into it on Monday!
|
!sync |
|
It looks like I can't sync this because of the merge conflict. @bgreni could you rebase and then I'll merge this? Thanks! 🙂 |
ConnorGray
added
the
waiting for response
bgreni
force-pushed
the
optional-str-repr
branch
from
9306141
to
48f11c9
Compare
Done now, apologies for the delay! |
No worries at all, thank you for fixing the conflict! I'll sync this in now. |
|
!sync |
ConnorGray
removed
the
waiting for response
modularbot
added
the
imported-internally
Signed-off-by: Brian Grenier <[email protected]>
bgreni
force-pushed
the
optional-str-repr
branch
from
48f11c9
to
ef67c5e
Compare
Add
format_to__str__and__repr__